feat: add react email implementation - #574
Open
sdrejkarz wants to merge 17 commits into
Open
Conversation
sdrejkarz
force-pushed
the
feat/react-email-implementation
branch
from
May 22, 2024 13:45
47c5c0e to
f73e2bb
Compare
sdrejkarz
marked this pull request as ready for review
May 22, 2024 14:18
sdrejkarz
force-pushed
the
feat/react-email-implementation
branch
from
May 23, 2024 11:50
f73e2bb to
2e97336
Compare
sdrejkarz
commented
May 23, 2024
| ### Sending test emails | ||
|
|
||
| Sending test emails is made easy with the ability to send test emails directly from a Storybook to Mailcatcher service. | ||
| Sending test emails is made easy with the ability to send test emails directly from a React.Email via Resend. |
Contributor
Author
There was a problem hiding this comment.
Built-in Resend works fine, but I haven't managed to send the image (logo).
| "@sb/webapp-finances": "workspace:*", | ||
| "juice": "^8.1.0" | ||
| "juice": "^8.1.0", | ||
| "react-email": "2.1.3" |
Contributor
Author
There was a problem hiding this comment.
niticking: I'm thinking of moving react-email to the devDependencies, as it will be used only locally.
sdrejkarz
force-pushed
the
feat/react-email-implementation
branch
from
May 27, 2024 08:02
3298c40 to
446f538
Compare
sdrejkarz
force-pushed
the
feat/react-email-implementation
branch
from
May 27, 2024 08:02
446f538 to
b377549
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Add React.email implementation and remove styled-components.
After the merge this issue is redundant.
What is the current behavior?
Emails are styled by styled-components - issue
What is the new behavior?
Emails are styled by tailwind